You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by sebb <se...@gmail.com> on 2008/07/05 14:29:11 UTC
Re: svn commit: r674186 - in /httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http: client/methods/ impl/client/ impl/conn/ impl/conn/tsccm/
On 05/07/2008, olegk@apache.org <ol...@apache.org> wrote:
> Author: olegk
> Date: Sat Jul 5 05:18:54 2008
> New Revision: 674186
>
> URL: http://svn.apache.org/viewvc?rev=674186&view=rev
> Log:
> HTTPCLIENT-745: made classes with private package visibility public
>
> Modified:
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpEntityEnclosingRequestBase.java
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpRequestBase.java
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/EntityEnclosingRequestWrapper.java
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/RequestWrapper.java
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionInputBuffer.java
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionOutputBuffer.java
> httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpEntityEnclosingRequestBase.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpEntityEnclosingRequestBase.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpEntityEnclosingRequestBase.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpEntityEnclosingRequestBase.java Sat Jul 5 05:18:54 2008
> @@ -46,7 +46,7 @@
> *
> * @since 4.0
> */
> -abstract class HttpEntityEnclosingRequestBase
> +public abstract class HttpEntityEnclosingRequestBase
> extends HttpRequestBase implements HttpEntityEnclosingRequest {
>
> private HttpEntity entity;
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpRequestBase.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpRequestBase.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpRequestBase.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/methods/HttpRequestBase.java Sat Jul 5 05:18:54 2008
> @@ -56,7 +56,7 @@
> *
> * @since 4.0
> */
> -abstract class HttpRequestBase extends AbstractHttpMessage
> +public abstract class HttpRequestBase extends AbstractHttpMessage
> implements HttpUriRequest, AbortableHttpRequest, Cloneable {
>
> private Lock abortLock;
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/EntityEnclosingRequestWrapper.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/EntityEnclosingRequestWrapper.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/EntityEnclosingRequestWrapper.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/EntityEnclosingRequestWrapper.java Sat Jul 5 05:18:54 2008
> @@ -51,7 +51,7 @@
> *
> * @since 4.0
> */
> -class EntityEnclosingRequestWrapper extends RequestWrapper
> +public class EntityEnclosingRequestWrapper extends RequestWrapper
> implements HttpEntityEnclosingRequest {
>
> private HttpEntity entity;
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/RequestWrapper.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/RequestWrapper.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/RequestWrapper.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/RequestWrapper.java Sat Jul 5 05:18:54 2008
> @@ -57,7 +57,7 @@
> *
> * @since 4.0
> */
> -class RequestWrapper extends AbstractHttpMessage implements HttpUriRequest {
> +public class RequestWrapper extends AbstractHttpMessage implements HttpUriRequest {
>
> private final HttpRequest original;
>
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionInputBuffer.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionInputBuffer.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionInputBuffer.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionInputBuffer.java Sat Jul 5 05:18:54 2008
> @@ -45,7 +45,7 @@
> *
> * @since 4.0
> */
> -class LoggingSessionInputBuffer implements SessionInputBuffer {
> +public class LoggingSessionInputBuffer implements SessionInputBuffer {
>
> /** Original session input buffer. */
> private final SessionInputBuffer in;
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionOutputBuffer.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionOutputBuffer.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionOutputBuffer.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/LoggingSessionOutputBuffer.java Sat Jul 5 05:18:54 2008
> @@ -43,7 +43,7 @@
> *
> * @since 4.0
> */
> -class LoggingSessionOutputBuffer implements SessionOutputBuffer {
> +public class LoggingSessionOutputBuffer implements SessionOutputBuffer {
>
> /** Original data transmitter. */
> private final SessionOutputBuffer out;
>
> Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java?rev=674186&r1=674185&r2=674186&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java (original)
> +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java Sat Jul 5 05:18:54 2008
> @@ -76,18 +76,5 @@
> return this.route;
> }
>
> -
> - /* *
> - * Indicates whether this reference is still valid.
> - *
> - * @return <code>true</code> if the pool entry is still referenced,
> - * <code>false</code> otherwise
> - * /
> - public final boolean isValid() {
> - //@@@ better sematics: allow explicit invalidation
> - return (super.get() != null);
> - }
> - */
> -
Was the removal of that method intentional?
It's not mentioned in the log message...
> } // class BasicPoolEntryRef
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: svn commit: r674186
Posted by sebb <se...@gmail.com>.
On 05/07/2008, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sat, 2008-07-05 at 13:29 +0100, sebb wrote:
> > On 05/07/2008, olegk@apache.org <ol...@apache.org> wrote:
> > > Author: olegk
> > > Date: Sat Jul 5 05:18:54 2008
> > > New Revision: 674186
> > >
>
> ...
>
> > >
> > > Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java
> > > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java?rev=674186&r1=674185&r2=674186&view=diff
> > > ==============================================================================
> > > --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java (original)
> > > +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java Sat Jul 5 05:18:54 2008
> > > @@ -76,18 +76,5 @@
> > > return this.route;
> > > }
> > >
> > > -
> > > - /* *
> > > - * Indicates whether this reference is still valid.
> > > - *
> > > - * @return <code>true</code> if the pool entry is still referenced,
> > > - * <code>false</code> otherwise
> > > - * /
> > > - public final boolean isValid() {
> > > - //@@@ better sematics: allow explicit invalidation
> > > - return (super.get() != null);
> > > - }
> > > - */
> > > -
> >
> > Was the removal of that method intentional?
> >
> > It's not mentioned in the log message...
> >
>
> Sebastian,
>
> This method was commented out. I thought it was pointless to keep it.
Sorry, my mistake.
I'd not noticed the subtle commenting out.
> Oleg
>
>
>
> > > } // class BasicPoolEntryRef
> > >
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: svn commit: r674186
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2008-07-05 at 13:29 +0100, sebb wrote:
> On 05/07/2008, olegk@apache.org <ol...@apache.org> wrote:
> > Author: olegk
> > Date: Sat Jul 5 05:18:54 2008
> > New Revision: 674186
> >
...
> >
> > Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java
> > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java?rev=674186&r1=674185&r2=674186&view=diff
> > ==============================================================================
> > --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java (original)
> > +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java Sat Jul 5 05:18:54 2008
> > @@ -76,18 +76,5 @@
> > return this.route;
> > }
> >
> > -
> > - /* *
> > - * Indicates whether this reference is still valid.
> > - *
> > - * @return <code>true</code> if the pool entry is still referenced,
> > - * <code>false</code> otherwise
> > - * /
> > - public final boolean isValid() {
> > - //@@@ better sematics: allow explicit invalidation
> > - return (super.get() != null);
> > - }
> > - */
> > -
>
> Was the removal of that method intentional?
>
> It's not mentioned in the log message...
>
Sebastian,
This method was commented out. I thought it was pointless to keep it.
Oleg
> > } // class BasicPoolEntryRef
> >
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org