[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23295: [FLINK-26341][zookeeper] Upgrade all tests related to ZooKeeperTestEnvironment to junit5 and removing the ZooKeeperTestEnvironment

["Jiabao-Sun (via GitHub)" <gi...@apache.org>]

Jiabao-Sun commented on code in PR #23295:
URL: https://github.com/apache/flink/pull/23295#discussion_r1306414698


##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStoreTest.java:
##########
@@ -162,16 +160,16 @@ public void testGetAllCheckpoints() throws Exception {
 
         List<CompletedCheckpoint> actual = checkpoints.getAllCheckpoints();
 
-        assertEquals(expected.length, actual.size());
+        assertThat(actual).hasSameSizeAs(expected);
 
         for (int i = 0; i < expected.length; i++) {
-            assertEquals(expected[i], actual.get(i));
+            assertThat(actual.get(i)).isEqualTo(expected[i]);

Review Comment:
   ```java
   assertThat(actual).containsExactly(expected);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org