[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5218: Improve logs of KubernetesApplicationOperation

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #5218:
URL: https://github.com/apache/kyuubi/pull/5218#discussion_r1309683497


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -172,23 +171,23 @@ class KubernetesApplicationOperation extends ApplicationOperation with Logging {
         case (NOT_FOUND, Some(_submitTime)) =>
           val elapsedTime = System.currentTimeMillis - _submitTime
           if (elapsedTime > submitTimeout) {
-            error(s"Can't find target driver pod by tag: $tag, " +
+            error(s"Can't find target driver pod by ${toLabel(tag)}, " +
               s"elapsed time: ${elapsedTime}ms exceeds ${submitTimeout}ms.")
             ApplicationInfo.NOT_FOUND
           } else {
-            warn("Wait for driver pod to be created, " +
+            warn(s"Waiting for driver pod with ${toLabel(tag)} to be created, " +

Review Comment:
   this message does not contains tag before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org