[jira] [Commented] (ARROW-1184) [Java] Dictionary.equals is not working correctly

["Bryan Cutler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073992#comment-16073992 ] 

Bryan Cutler commented on ARROW-1184:
-------------------------------------

I think that comparing any 2 FieldVectors could get pretty complicated, especially with nested types, so maybe that's why FieldVector.equals() is not implemented.  Validator.java has a comparison but I think that would probably fail for some cases.  I'm not sure we can assume flat fields only for the dictionary vector to try to make it easier.

> [Java] Dictionary.equals is not working correctly
> -------------------------------------------------
>
>                 Key: ARROW-1184
>                 URL: https://issues.apache.org/jira/browse/ARROW-1184
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>
> The {{Dictionary.equals}} method does not return True when the dictionaries are equal.  This is because {{equals}} is not implemented for FieldVector and so that comparison defaults to comparing the two objects only and not the vector data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)