You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "noblepaul (via GitHub)" <gi...@apache.org> on 2024/01/16 14:42:06 UTC
[PR] Enable PRS for all cloud tests [solr]
noblepaul opened a new pull request, #2199:
URL: https://github.com/apache/solr/pull/2199
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Enable PRS for all cloud tests [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-2019129031
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Enable PRS for all cloud tests [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-2484420270
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Enable PRS for all cloud tests [solr]
Posted by "magibney (via GitHub)" <gi...@apache.org>.
magibney commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-1894015934
Should we instead have this default at the lowest level to being randomized, or otherwise ensure that nothing (either now or future) falls through the cracks?
This would yield a much smaller diff, but more importantly: having the randomized/configurable default at a lower level would improve confidence that we're achieving the goal of test coverage for both PRS and non-PRS case. Ideally it'd be nice to only explicitly specify `CollectionAdminRequest.setPerReplicaState(boolean)` when a test is actually testing behavior that relies specifically on PRS or non-PRS.
Specifically, I'm wondering about changing [this line](https://github.com/apache/solr/blob/b5db179164919df657845f5e71f9fe0f0a1c86d8/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java#L687-L689):
```diff
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
@@ -684,7 +684,7 @@ public abstract class CollectionAdminRequest<T extends CollectionAdminResponse>
addProperties(params, properties);
}
numReplicas.writeProps(params);
- if (Boolean.TRUE.equals(perReplicaState)) {
+ if (perReplicaState == null ? DEFAULT_PRS : Boolean.TRUE.equals(perReplicaState)) {
params.set(CollectionAdminParams.PER_REPLICA_STATE, perReplicaState);
}
params.setNonNull(ALIAS, alias);
```
... where `DEFAULT_PRS` would be a new boolean constant (or pseudo-constant) initialized via sysprop (analogous to current `SolrCloudTestCase.USE_PER_REPLICA_STATE`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Enable PRS for all cloud tests [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-2358965812
@noblepaul status on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Enable PRS for all cloud tests [solr]
Posted by "noblepaul (via GitHub)" <gi...@apache.org>.
noblepaul commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-1903290421
>Should we instead have this default at the lowest level to being randomized, or otherwise ensure that nothing (either now or future) falls through the cracks?
I think we should explore that. We do have tests that do PRS on and off explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Enable PRS for all cloud tests [solr]
Posted by "hiteshk25 (via GitHub)" <gi...@apache.org>.
hiteshk25 commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-1904395389
do we log somewhere whether collection has prs(or not)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org