You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/11/17 01:37:35 UTC
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16736
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
kudu-3210 added FIPS compliant changes for Kudu.
In previous patch, we ported the following patches for kudu-3210 into
Impala source tree:
http://gerrit.cloudera.org:8080/16631/
http://gerrit.cloudera.org:8080/16657/
http://gerrit.cloudera.org:8080/16658/
http://gerrit.cloudera.org:8080/16659/
The last patch http://gerrit.cloudera.org:8080/16659/ fixed an OpenSSL
race condition with work around by adding lock before verifying
signature. But this issue could be fixed by redefining the thread ID
callback without any additional locking.
Kudu reverted commit f9f3189a6dbe0636d578d80b1d8e60cf7b2e6686
and added a new patch to redefine the thread ID callback.
https://gerrit.cloudera.org/#/c/16730/
https://gerrit.cloudera.org/#/c/16731/
This patch syncs Kudu's code changes of above two patches.
Testing:
- Passed exhausive tests.
Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
---
M be/src/kudu/security/CMakeLists.txt
M be/src/kudu/security/crypto.cc
M be/src/kudu/security/openssl_util.cc
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/tls_context.cc
M be/src/kudu/security/tls_handshake.cc
6 files changed, 22 insertions(+), 96 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/16736/1
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
kudu-3210 added FIPS compliant changes for Kudu.
In previous patch, we ported the following patches for kudu-3210 into
Impala source tree:
http://gerrit.cloudera.org:8080/16631/
http://gerrit.cloudera.org:8080/16657/
http://gerrit.cloudera.org:8080/16658/
http://gerrit.cloudera.org:8080/16659/
The last patch http://gerrit.cloudera.org:8080/16659/ fixed an OpenSSL
race condition with work around by adding lock before verifying
signature. But this issue could be fixed by redefining the thread ID
callback without any additional locking.
Kudu reverted commit f9f3189a6dbe0636d578d80b1d8e60cf7b2e6686
and added a new patch to redefine the thread ID callback.
https://gerrit.cloudera.org/#/c/16730/
https://gerrit.cloudera.org/#/c/16731/
This patch syncs Kudu's code changes of above two patches.
Testing:
- Passed exhausive tests.
Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Reviewed-on: http://gerrit.cloudera.org:8080/16736
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/kudu/security/CMakeLists.txt
M be/src/kudu/security/crypto.cc
M be/src/kudu/security/openssl_util.cc
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/tls_context.cc
M be/src/kudu/security/tls_handshake.cc
6 files changed, 22 insertions(+), 96 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Attila Bukor: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 10:43:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1:
Hit irrelevant DCHECK error in RuntimeProfileBase::total_time_counter(). It's same as IMPALA-10276.
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 16:12:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6657/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 06:12:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 23:02:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6657/
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 11:56:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 06:12:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7659/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 01:58:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 )
Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6660/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b9d46b5d7228289565617b8d3cfbef9f3b5ba3
Gerrit-Change-Number: 16736
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 17:39:42 +0000
Gerrit-HasComments: No