You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2015/10/17 15:43:05 UTC
[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/14
CB-8973: Changed the functionality of making the log appear and disap…
…pear
Fixes a typo `classList.add` -> `classList.remove`.
Adds JS logic to adjust content/log height and margins on log show/hide and window resize for Windows platform.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8973-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-test-framework/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit e9808da76b6e10eb0ecba55d7631f6d138146122
Author: daserge <v-...@microsoft.com>
Date: 2015-10-17T13:34:21Z
CB-8973: Changed the functionality of making the log appear and disappear
Fixes a typo classList.add -> classList.remove
Adds JS logic to adjust content/log height and margins on log show/hide and window resize for Windows platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/14#issuecomment-149079635
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org