[GitHub] [flink] KurtYoung commented on a change in pull request #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog

[GitBox <gi...@apache.org>]

KurtYoung commented on a change in pull request #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog
URL: https://github.com/apache/flink/pull/8222#discussion_r278387973
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
 ##########
 @@ -33,30 +35,53 @@
 public class GenericCatalogTable implements CatalogTable {
 	// Schema of the table (column names and types)
 	private final TableSchema tableSchema;
-	// Properties of the table
-	private final Map<String, String> properties;
 	// Statistics of the table
 	private final TableStats tableStats;
+	// Partition keys if this is a partitioned table. It's an empty set if the table is not partitioned
+	private final List<String> partitionKeys;
+	// Properties of the table
+	private final Map<String, String> properties;
 	// Comment of the table
 	private String comment = "This is a generic catalog table.";
 
-	public GenericCatalogTable(TableSchema tableSchema, TableStats tableStats, Map<String, String> properties) {
-		this.tableSchema = tableSchema;
-		this.tableStats = tableStats;
+	public GenericCatalogTable(
+		TableSchema tableSchema,
 
 Review comment:
   We need to indent 2 tabs here, so you don't need to leave a blank line in the beginning of this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services