You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2015/11/13 11:42:40 UTC
svn commit: r1714181 -
/subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py
Author: julianfoad
Date: Fri Nov 13 10:42:40 2015
New Revision: 1714181
URL: http://svn.apache.org/viewvc?rev=1714181&view=rev
Log:
On the 'move-tracking-2' branch: Let the test suite read the output from
'svnmover' in normal text mode, to normalize line endings on Windows, to
fix a failure of svnmover_tests 11 on Windows.
* subversion/tests/cmdline/svntest/main.py
(run_svnmover): Don't use 'binary' mode.
Modified:
subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py
Modified: subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py
URL: http://svn.apache.org/viewvc/subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py?rev=1714181&r1=1714180&r2=1714181&view=diff
==============================================================================
--- subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py (original)
+++ subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py Fri Nov 13 10:42:40 2015
@@ -777,7 +777,7 @@ def run_svnversion(*varargs):
def run_svnmover(*varargs):
"""Run svnmover with VARARGS, returns exit code as int; stdout, stderr as
list of lines (including line terminators). Use binary mode for output."""
- return run_command(svnmover_binary, 1, True,
+ return run_command(svnmover_binary, 1, False,
*(_with_auth(_with_config_dir(varargs))))
def run_svnmucc(*varargs):
Re: svn commit: r1714181 - /subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py
Posted by Julian Foad <ju...@apache.org>.
Bert Huijben wrote:
> Julian Foad wrote:
> > URL: http://svn.apache.org/viewvc?rev=1714181&view=rev
[...]
> > def run_svnmover(*varargs):
> > """Run svnmover with VARARGS, returns exit code as int; stdout, stderr as
> > list of lines (including line terminators). Use binary mode for output."""
> > - return run_command(svnmover_binary, 1, True,
> > + return run_command(svnmover_binary, 1, False,
> > *(_with_auth(_with_config_dir(varargs))))
>
> You missed changing the comment here that documents that you explicitly use binary output.
Thanks. Fixed in r1714499.
- Julian
RE: svn commit: r1714181 - /subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: julianfoad@apache.org [mailto:julianfoad@apache.org]
> Sent: vrijdag 13 november 2015 11:43
> To: commits@subversion.apache.org
> Subject: svn commit: r1714181 - /subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py
>
> Author: julianfoad
> Date: Fri Nov 13 10:42:40 2015
> New Revision: 1714181
>
> URL: http://svn.apache.org/viewvc?rev=1714181&view=rev
> Log:
> On the 'move-tracking-2' branch: Let the test suite read the output from
> 'svnmover' in normal text mode, to normalize line endings on Windows, to
> fix a failure of svnmover_tests 11 on Windows.
>
> * subversion/tests/cmdline/svntest/main.py
> (run_svnmover): Don't use 'binary' mode.
>
> Modified:
> subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py
>
> Modified: subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py
> URL: http://svn.apache.org/viewvc/subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py?rev=1714181&r1=1714180&r2=
> 1714181&view=diff
> ==========================================================
> ====================
> --- subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py (original)
> +++ subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py Fri Nov 13 10:42:40 2015
> @@ -777,7 +777,7 @@ def run_svnversion(*varargs):
> def run_svnmover(*varargs):
> """Run svnmover with VARARGS, returns exit code as int; stdout, stderr as
> list of lines (including line terminators). Use binary mode for output."""
> - return run_command(svnmover_binary, 1, True,
> + return run_command(svnmover_binary, 1, False,
> *(_with_auth(_with_config_dir(varargs))))
You missed changing the comment here that documents that you explicitly use binary output.
Bert