[GitHub] [spark] cloud-fan commented on a change in pull request #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise for array cases

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise for array cases
URL: https://github.com/apache/spark/pull/23867#discussion_r261907906
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
 ##########
 @@ -381,22 +390,7 @@ case class GetMapValue(child: Expression, key: Expression)
   override def right: Expression = key
 
   /** `Null` is returned for invalid ordinals. */
 
 Review comment:
   we need to update this comment, to say why the nullability is always true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org