[GitHub] wes3 opened a new pull request #1292: hw/battery: Fix incorrect comparisons to os_time

[GitBox <gi...@apache.org>]

wes3 opened a new pull request #1292: hw/battery: Fix incorrect comparisons to os_time
URL: https://github.com/apache/mynewt-core/pull/1292
 
 
   The battery code was directly comparing os_time values within
   using the macros intended for comparing two os_time values. There
   is a feature change with this commit. The change is to the code
   that sets the poll rate for a battery. The new code simply sets
   the callout to fire off immediately if the battery poll rate is
   changed. Decided that this is just simpler and there is no need
   to check when the battery was last polled and only poll immediately
   if the difference between now and the last time it was polled is
   greater than the new poll rate. This code also did not check all
   the batteries being polled so it could possibly miss a polling
   interval if there are multiple battery devices being polled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services