You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 04:32:35 UTC
[GitHub] [arrow-datafusion] yjshen opened a new pull request, #2198: minor: pin lock_api 0.4.6 to avoid the need for nightly
yjshen opened a new pull request, #2198:
URL: https://github.com/apache/arrow-datafusion/pull/2198
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
Encounter the need for nightly while running `datafusion-cli`, pin `lock_api` version to `0.4.6` could fix.
```
error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
--> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/lock_api-0.4.7/src/mutex.rs:150:6
|
150 | impl<R: RawMutex, T> Mutex<R, T> {
| ^
...
154 | pub const fn new(val: T) -> Mutex<R, T> {
| --------------------------------------- function declared as const here
|
= note: see issue #93706 <https://github.com/rust-lang/rust/issues/93706> for more information
= help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable
error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
--> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/lock_api-0.4.7/src/remutex.rs:231:6
|
231 | impl<R: RawMutex, G: GetThreadId, T> ReentrantMutex<R, G, T> {
| ^
...
235 | pub const fn new(val: T) -> ReentrantMutex<R, G, T> {
| --------------------------------------------------- function declared as const here
|
= note: see issue #93706 <https://github.com/rust-lang/rust/issues/93706> for more information
= help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable
error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
--> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/lock_api-0.4.7/src/remutex.rs:231:19
|
231 | impl<R: RawMutex, G: GetThreadId, T> ReentrantMutex<R, G, T> {
| ^
...
235 | pub const fn new(val: T) -> ReentrantMutex<R, G, T> {
| --------------------------------------------------- function declared as const here
|
= note: see issue #93706 <https://github.com/rust-lang/rust/issues/93706> for more information
= help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable
error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
--> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/lock_api-0.4.7/src/rwlock.rs:367:6
|
367 | impl<R: RawRwLock, T> RwLock<R, T> {
| ^
...
371 | pub const fn new(val: T) -> RwLock<R, T> {
| ---------------------------------------- function declared as const here
|
= note: see issue #93706 <https://github.com/rust-lang/rust/issues/93706> for more information
= help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable
For more information about this error, try `rustc --explain E0658`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen closed pull request #2198: minor: pin lock_api 0.4.6 to avoid the need for nightly
Posted by GitBox <gi...@apache.org>.
yjshen closed pull request #2198: minor: pin lock_api 0.4.6 to avoid the need for nightly
URL: https://github.com/apache/arrow-datafusion/pull/2198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #2198: minor: pin lock_api 0.4.6 to avoid the need for nightly
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2198:
URL: https://github.com/apache/arrow-datafusion/pull/2198#issuecomment-1096230119
I can't seem to reproduce this locally using stable Rust 1.59 or 1.60, is it possible you were accidentally compiling with an old nightly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on pull request #2198: minor: pin lock_api 0.4.6 to avoid the need for nightly
Posted by GitBox <gi...@apache.org>.
yjshen commented on PR #2198:
URL: https://github.com/apache/arrow-datafusion/pull/2198#issuecomment-1096292364
I cannot reproduce this after updating rust. Thanks @tustvold!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org