You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/06 13:08:58 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #4966: Python: Keep runtime typing
Fokko opened a new pull request, #4966:
URL: https://github.com/apache/iceberg/pull/4966
Pyupgrade would update `Dict[str, Any]` to `dict[str, Any]` which
isn't allowed in Python 3.8, breaking the tests with an obscure error:
```
ImportError while loading conftest '/Users/fokkodriesprong/Desktop/iceberg/python/tests/conftest.py'.
../conftest.py:34: in <module>
from iceberg import schema
../../src/iceberg/schema.py:47: in <module>
class Schema(IcebergBaseModel):
pydantic/main.py:188: in pydantic.main.ModelMetaclass.__new__
???
pydantic/typing.py:419: in pydantic.typing.resolve_annotations
???
/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/typing.py:270: in _eval_type
return t._evaluate(globalns, localns)
/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/typing.py:518: in _evaluate
eval(self.__forward_code__, globalns, localns),
E TypeError: 'type' object is not subscriptable
```
Therefore we should disable them (until we go to Python 3.9 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #4966: Python: Keep runtime typing
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #4966:
URL: https://github.com/apache/iceberg/pull/4966#issuecomment-1147483789
It seems to be something specific to my branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko closed pull request #4966: Python: Keep runtime typing
Posted by GitBox <gi...@apache.org>.
Fokko closed pull request #4966: Python: Keep runtime typing
URL: https://github.com/apache/iceberg/pull/4966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #4966: Python: Keep runtime typing
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #4966:
URL: https://github.com/apache/iceberg/pull/4966#issuecomment-1147454563
We'll probably need to revert some of the changes: https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html#built-in-types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org