You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/27 04:20:55 UTC
[GitHub] [incubator-mxnet] ehsanmok opened a new pull request #17443:
[MXNET-1443] Change gluon contrib base event handlers to mixins
ehsanmok opened a new pull request #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
URL: https://github.com/apache/incubator-mxnet/pull/17443
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
incubator-mxnet/python/mxnet/gluon/contrib/estimator/event_handler.py
incubator-mxnet/python/mxnet/gluon/contrib/estimator/estimator.py
incubator-mxnet/tests/python/unittest/test_gluon_event_handler.py
incubator-mxnet/tests/python/unittest/test_gluon_estimator.py
incubator-mxnet/docs/python_docs/python/tutorials/packages/gluon/training/fit_api_tutorial.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ehsanmok commented on issue #17443: [MXNET-1443]
Change gluon contrib base event handlers to mixins
Posted by GitBox <gi...@apache.org>.
ehsanmok commented on issue #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
URL: https://github.com/apache/incubator-mxnet/pull/17443#issuecomment-598826261
@szha Sounds good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ehsanmok commented on issue #17443: [MXNET-1443]
Change gluon contrib base event handlers to mixins
Posted by GitBox <gi...@apache.org>.
ehsanmok commented on issue #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
URL: https://github.com/apache/incubator-mxnet/pull/17443#issuecomment-578881760
@leezu Since contrib would likely become stable at some point, I'm in favor of changing them sooner from both dev and user sides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ehsanmok commented on issue #17443: [MXNET-1443]
Change gluon contrib base event handlers to mixins
Posted by GitBox <gi...@apache.org>.
ehsanmok commented on issue #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
URL: https://github.com/apache/incubator-mxnet/pull/17443#issuecomment-578800905
@szha Mixins show users don't need to care about MRO when inheriting from multiple classes. So this change is a technical correction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17443: [MXNET-1443]
Change gluon contrib base event handlers to mixins
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
URL: https://github.com/apache/incubator-mxnet/pull/17443#issuecomment-578859731
I agree the new name is more self-explanatory, but changing may break user code. This is experimental API, so changes are fine if needed. Would such docstring be sufficient without introducing breakage? `"""BatchEnd Mixin."""`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17443: [MXNET-1443]
Change gluon contrib base event handlers to mixins
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
URL: https://github.com/apache/incubator-mxnet/pull/17443#issuecomment-578901734
CC @liuzh91 who wrote code that would break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ehsanmok closed pull request #17443: [MXNET-1443] Change gluon contrib base event handlers to mixins
Posted by GitBox <gi...@apache.org>.
ehsanmok closed pull request #17443:
URL: https://github.com/apache/incubator-mxnet/pull/17443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org