You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/29 17:55:44 UTC

[GitHub] [spark] huaxingao opened a new pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

huaxingao opened a new pull request #28409:
URL: https://github.com/apache/spark/pull/28409


   ### What changes were proposed in this pull request?
   Add VarianceThresholdSelector to PySpark
   
   
   ### Why are the changes needed?
   parity between Scala and Python
   
   
   ### Does this PR introduce any user-facing change?
   Yes. 
   VarianceThresholdSelector is added to PySpark
   
   
   ### How was this patch tested?
   new doctest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624082928






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624069467


   **[Test build #122317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122317/testReport)** for PR 28409 at commit [`1c0a38a`](https://github.com/apache/spark/commit/1c0a38a0938c6f8a5c00a4cd00a07ca5d1d158c6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624082318


   **[Test build #122317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122317/testReport)** for PR 28409 at commit [`1c0a38a`](https://github.com/apache/spark/commit/1c0a38a0938c6f8a5c00a4cd00a07ca5d1d158c6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class _VarianceThresholdSelectorParams(HasFeaturesCol, HasOutputCol):`
     * `class VarianceThresholdSelector(JavaEstimator, _VarianceThresholdSelectorParams, JavaMLReadable,`
     * `class VarianceThresholdSelectorModel(JavaModel, _VarianceThresholdSelectorParams, JavaMLReadable,`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-621369906


   **[Test build #122081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122081/testReport)** for PR 28409 at commit [`1c0a38a`](https://github.com/apache/spark/commit/1c0a38a0938c6f8a5c00a4cd00a07ca5d1d158c6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-621382126


   **[Test build #122081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122081/testReport)** for PR 28409 at commit [`1c0a38a`](https://github.com/apache/spark/commit/1c0a38a0938c6f8a5c00a4cd00a07ca5d1d158c6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class _VarianceThresholdSelectorParams(HasFeaturesCol, HasOutputCol):`
     * `class VarianceThresholdSelector(JavaEstimator, _VarianceThresholdSelectorParams, JavaMLReadable,`
     * `class VarianceThresholdSelectorModel(JavaModel, _VarianceThresholdSelectorParams, JavaMLReadable,`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-621382608






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624699316


   Thanks! @srowen @zhengruifeng 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624070219






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624068104


   Jenkins test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-623888814


   cc @srowen @zhengruifeng 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624070219






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-621370785






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624082928






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-621382608






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-621369906


   **[Test build #122081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122081/testReport)** for PR 28409 at commit [`1c0a38a`](https://github.com/apache/spark/commit/1c0a38a0938c6f8a5c00a4cd00a07ca5d1d158c6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624069467


   **[Test build #122317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122317/testReport)** for PR 28409 at commit [`1c0a38a`](https://github.com/apache/spark/commit/1c0a38a0938c6f8a5c00a4cd00a07ca5d1d158c6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #28409: [SPARK-31609][ML][PySpark] Add VarianceThresholdSelector to PySpark

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28409:
URL: https://github.com/apache/spark/pull/28409#issuecomment-624673524


   Merged to master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org