[GitHub] [spark] MaxGekk commented on a change in pull request #25963: [SPARK-28137][SQL] Add Postgresql function to_number.

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #25963: [SPARK-28137][SQL] Add Postgresql function to_number.
URL: https://github.com/apache/spark/pull/25963#discussion_r333036207
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
 ##########
 @@ -840,6 +841,62 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
       Literal.create(null, IntegerType), Literal.create(null, IntegerType)), null)
   }
 
+  test("ToNumber") {
 
 Review comment:
   The `usage` part of the expressions says that some part of patterns can use locale:
   ```
   'S': sign anchored to number (uses locale)
         'L': currency symbol (uses locale)
         'D': decimal point (uses locale)
         'G': group separator (uses locale)
   ```
   Could you test a few locales.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org