You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2026/10/15 15:49:57 UTC
[PR] fix(grafana): correct consumer dashboard group filtering [rocketmq-dashboard]
yx9o opened a new pull request, #6765:
URL: https://github.com/apache/rocketmq-dashboard/pull/6765
### Brief Description
Fix the bundled Consumer dashboard's "Messages Out TPS by Group" panel. It references `$group` without defining that variable and queries the `group` label, while RocketMQ native metrics use `consumer_group`.
- Define a consumer group variable from `rocketmq_messages_out_total`, scoped to the selected cluster.
- Use `consumer_group` in the TPS selector, aggregation, and legend.
- Regenerate the bundled Consumer dashboard and add regression coverage for its variables, query, and consistency with the generator.
### How Did You Test This Change?
- `python3 -m unittest discover -s server/scripts -p test_gen_grafana_dashboards.py`: 10 tests passed. The two new regressions failed against unchanged production code on the current base.
- `cd server && mvn -B -ntp -Dtest=GrafanaDashboardServiceTest,GrafanaDashboardControllerTest test`: 18 tests passed, with zero failures, errors, or skipped tests; compilation and Checkstyle passed.
- Regenerated all dashboard assets and confirmed that only `rocketmq-consumer.json` changed.
- `git diff --check` passed.
- Independent code review found no actionable issues.
No live Grafana import or Prometheus query execution was performed.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`fix:`)
- [x] Regression tests added using the existing Python unittest conventions
- [x] Bilingual Studio UI text requirement is not applicable; no Studio UI text added
- [x] Architecture boundaries reviewed; no Java source or dependency changes
- [x] ASF header requirement for new sources is not applicable; no new source files
- [x] Dashboard assets and their generator updated together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(grafana): correct consumer dashboard group filtering [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6765:
URL: https://github.com/apache/rocketmq-dashboard/pull/6765#issuecomment-6391335436
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(grafana): correct consumer dashboard group filtering [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6765: fix(grafana): correct consumer dashboard group filtering
URL: https://github.com/apache/rocketmq-dashboard/pull/6765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org