You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org> on 2012/01/17 02:11:38 UTC

[jira] [Commented] (GIRAPH-124) Combiner should return Iterable instead of M or null.

    [ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187352#comment-13187352 ] 

Claudio Martella commented on GIRAPH-124:
-----------------------------------------

As discussed in mailing-list, there are two possible approaches on how to manage a returned Iterable<M> with more messages than the input set: a warning in the logs or an exception. We should take a decision about it.
                
> Combiner should return Iterable<M> instead of M or null.
> --------------------------------------------------------
>
>                 Key: GIRAPH-124
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-124
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.1.0
>            Reporter: Claudio Martella
>
> Currently VertexCombiner is expected to return a single message combining the input messages, or null in case no message should be sent. The new expected interface should return an Iterable<M>, possibly empty. The number of elements in the returned Iterable is supposed to be smaller than the number of input messages, by the initial definition of a Combiner (defined as a function to reduce I/O by combining multiple messages into 1).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira