You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/29 23:38:14 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #648: Check
return from nxsem_wait_initialize()
patacongo opened a new pull request #648: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/648
Resolution of Issue 619 will require multiple steps, this part of the first step in that resolution: Every call to nxsem_wait_uninterruptible() must handle the return value from nxsem_wait_uninterruptible properly. This commit is only for those files under fs/inode. Utility functions under fs/incode were modified so the changes do extend to other fs/ sub-directories as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #648: Check return from
nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #648: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#648: Check return from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #648: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/648#discussion_r399874613
##########
File path: fs/mqueue/mq_unlink.c
##########
@@ -116,7 +101,13 @@ int mq_unlink(FAR const char *mq_name)
* functioning as a directory and the directory is not empty.
*/
- inode_semtake();
+ ret = inode_semtake();
+ if (ret < 0)
+ {
+ errcode = -ret;
+ goto errout_with_semaphore;
Review comment:
Yes.. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #648:
Check return from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #648: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/648#discussion_r399872927
##########
File path: fs/mqueue/mq_unlink.c
##########
@@ -116,7 +101,13 @@ int mq_unlink(FAR const char *mq_name)
* functioning as a directory and the directory is not empty.
*/
- inode_semtake();
+ ret = inode_semtake();
+ if (ret < 0)
+ {
+ errcode = -ret;
+ goto errout_with_semaphore;
Review comment:
Shouldn't be `errout_with_inode`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services