Re: svn commit: r356793 - in /logging/log4net/trunk/src: Appender/LocalSyslogAppender.cs AssemblyInfo.cs Layout/XMLLayout.cs Util/PropertiesDictionary.cs Util/ReadOnlyPropertiesDictionary.cs

[Gert Driesen <ge...@telenet.be>]

Nicko,

All Mono-related issue have been fixed in Mono svn. I reported a bunch of
issues during the process of getting log4net building on Mono again (without
warning), and all of them are definitely fixed (by Atsushi).

There might still be one issue that not been merged into gmcs, but log4net
compiles without any warning on the mono-1.0 profile (without your changes).

You can safely rollback these changes.

Gert

----- Original Message ----- 
From: "Nicko Cadell" <ni...@neoworks.com>
To: "Log4NET Dev" <lo...@logging.apache.org>
Sent: Wednesday, December 14, 2005 5:40 PM
Subject: RE: svn commit: r356793 - in /logging/log4net/trunk/src:
Appender/LocalSyslogAppender.cs AssemblyInfo.cs Layout/XMLLayout.cs
Util/PropertiesDictionary.cs Util/ReadOnlyPropertiesDictionary.cs





> >
> > PropertiesDictionary.cs & ReadOnlyPropertiesDictionary.cs
> > I can't find a way to cref the index operator (i.e. [])
> correctly on all
> platforms, so rewrote text not to have to link directly to
> the operator.
>
> On what framework/platform did this cause problems ?

I'm getting the following error from Mono-1.1.10.1 in the
compile-mono-1.0 target.


      [csc] Compiling 202 files to
'C:\work\svn_root\apache\log4net\trunk\bin\mono\1.0\debug\log4net.dll'.
      [csc]
C:\work\svn_root\apache\log4net\trunk\src\Util\PropertiesDictionary.cs(2
45,22): error CS1041: Identifier expected. 'this' is a keyword
      [csc]
C:\work\svn_root\apache\log4net\trunk\src\Util\PropertiesDictionary.cs(2
45,22): error CS1041: Identifier expected. 'this' is a keyword
      [csc] Compilation failed: 2 error(s), 0 warnings


This seems to be caused by the following doc comment:

/// See <see cref="IDictionary.this"/>

The mono compiler likes IDictionary[] rather than IDictionary.this, but
it does not like IDictionary[object] it must end with '[]'. The MS
compilers don't seem to like '[]' at all.




> > Modified:
> >     logging/log4net/trunk/src/Appender/LocalSyslogAppender.cs
>
> Why did you have to modify this ? On what framework was it
> causing problems
> for you ?


This is coming from the mono compiler in the 1.0 and 2.0 targets:

      [csc]
C:\work\svn_root\apache\log4net\trunk\src\Appender\LocalSyslogAppender.c
s(132,15): warning CS1574: XML comment on
`log4net.Appender.LocalSyslogAppender.SyslogFacility' has cref attribute
`Facility' that could not be resolved

I fixed this because it was a CS1574 warning as opposed to the CS0419
(Ambiguous reference in cref attribute) which I am ignoring. I have
temporarily changed the build file to exclude the following warnings
0618, 0419 and 1574. I was then going to work through these warnings and
see what I could do about fixing them.

Nicko




>
> Gert
>