[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2727: HDDS-5805. remove containerStateManager V1 code

[GitBox <gi...@apache.org>]

JacksonYao287 commented on a change in pull request #2727:
URL: https://github.com/apache/ozone/pull/2727#discussion_r732532666



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestUtils.java
##########
@@ -629,6 +630,20 @@ public static ContainerInfo getContainer(
             new RatisReplicationConfig(ReplicationFactor.THREE))
         .setState(state)
         .setSequenceId(10000L)
+        .setPipelineID(randomPipelineID)
+        .setOwner("TEST")
+        .build();
+  }
+
+  public static ContainerInfo getContainer(
+      final HddsProtos.LifeCycleState state, PipelineID pipelineID) {
+    return new ContainerInfo.Builder()
+        .setContainerID(RandomUtils.nextLong())
+        .setReplicationConfig(
+            new RatisReplicationConfig(ReplicationFactor.THREE))
+        .setState(state)
+        .setSequenceId(10000L)
+        .setPipelineID(pipelineID)
         .setOwner("TEST")
         .build();

Review comment:
       thank @adoroszlai for the review!  i will remove the duplicated code in a new commit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org