You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by aparnard <gi...@git.apache.org> on 2016/08/16 19:01:34 UTC

[GitHub] incubator-geode pull request #233: GEODE11: Fixing bugs in lucene gfsh comma...

GitHub user aparnard opened a pull request:

    https://github.com/apache/incubator-geode/pull/233

    GEODE11: Fixing bugs in lucene gfsh commands

    - When we use an user defined analyzer class in gfsh, the cluster hangs because the create region message that it sends has a LuceneIndexCreationProfile has a user defined analyzer class. Fixed this by storing only the class name in LuceneIndexCreationProfile.
    
    - Using the string "null" in the analyzer option for create lucene index command will now set the field analyzer to be StandardAnalyzer.
    
    - The lucene gfsh commands were available offline. Changed this behavior by adding CliAvailabilityIndicator.
    
    - The search results are sorted by score and the compareTo method caused the "Comparison method violates general contract" error when it returned multiple results with same score. Fixed this bug in the compareTo method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aparnard/incubator-geode feature/GEODE-11-cluster-hang-UDAnalyzer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #233
    
----
commit 9d633f5ae6086092373fa6c92cb064a049b506ef
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date:   2016-08-11T23:35:41Z

    GEODE-11: Fixing bug that arises while using user defined analyzer in gfsh.
    
    When we use an user defined analyzer class in gfsh, the cluster hangs because the create region message that is sent has a LuceneIndexCreationProfile has a user defined analyzer class. Fixed this by storing only the class name in LuceneIndexCreationProfile.
    
    Signed-off-by: Gester Zhou <gz...@pivotal.io>

commit 51bdb78872aea7bd8c6880b01650c076352b1319
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date:   2016-08-15T21:02:02Z

    GEODE-11: StandardAnalyzer is used when analyzer option is null
    
    Using the string "null" in the analyzer option for create lucene index command will now set the field analyzer to be StandardAnalyzer.

commit 0ed2a001261c4b0d72917a19ec0e8967f49f9c12
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date:   2016-08-15T22:25:02Z

    GEODE-11: Added CliAvailabilityIndicator to lucene gfsh commands
    
    The lucene gfsh commands were available offline. Changed this behavior by adding CliAvailabilityIndicator.

commit 0b2b220aa98a77b75b9facf3c9560df36336194c
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date:   2016-08-16T18:28:21Z

    GEODE-11:Fix for "Comparison method violates general contract"
    
    The search results are sorted by score and the compareTo method caused the "Comparison method violates general contract" error when it returned multiple results with same score.
    
    Signed-off-by: Gester Zhou <gz...@pivotal.io>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #233: GEODE11: Fixing bugs in lucene gfsh commands

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/incubator-geode/pull/233
  
    +1 Looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #233: GEODE11: Fixing bugs in lucene gfsh commands

Posted by agingade <gi...@git.apache.org>.
Github user agingade commented on the issue:

    https://github.com/apache/incubator-geode/pull/233
  
    Looks good...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #233: GEODE11: Fixing bugs in lucene gfsh comma...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/233


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #233: GEODE11: Fixing bugs in lucene gfsh commands

Posted by gesterzhou <gi...@git.apache.org>.
Github user gesterzhou commented on the issue:

    https://github.com/apache/incubator-geode/pull/233
  
    +1 after the new fix, the code and tests look good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---