You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "milindmantri (via GitHub)" <gi...@apache.org> on 2023/05/28 04:42:03 UTC
[GitHub] [kafka] milindmantri opened a new pull request, #13774: KAFKA-12562: Fix KafkaStreams#store old references in comments
milindmantri opened a new pull request, #13774:
URL: https://github.com/apache/kafka/pull/13774
Following method was deprecated in 2.5 and was removed in 3.0.0.
```java
// KafkaStreams.java
public <T> T store(final String storeName, final QueryableStoreType<T> queryableStoreType);
```
However, many comments reference the removed method which can be confusing in generated JavaDocs. The code in java doc comments has been changed to reflect the new method, `store(final StoreQueryParameters<T> storeQueryParameters)`.
Also, minor changes to variable names in java doc to be context specific.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] milindmantri commented on pull request #13774: KAFKA-12562: Fix KafkaStreams#store old references in comments
Posted by "milindmantri (via GitHub)" <gi...@apache.org>.
milindmantri commented on PR #13774:
URL: https://github.com/apache/kafka/pull/13774#issuecomment-1566032190
Related to https://github.com/apache/kafka/pull/10412
@guozhangwang, could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #13774: KAFKA-12562: Fix KafkaStreams#store old references in comments
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna merged PR #13774:
URL: https://github.com/apache/kafka/pull/13774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org