[GitHub] [cloudstack] rhtyd commented on a change in pull request #4033: kvm: suspend/resume in deleting vm snapshot on kvm

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #4033: kvm: suspend/resume in deleting vm snapshot on kvm
URL: https://github.com/apache/cloudstack/pull/4033#discussion_r409493080
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
 ##########
 @@ -58,6 +59,9 @@ public Answer execute(final DeleteVMSnapshotCommand cmd, final LibvirtComputingR
 
             snapshot = dm.snapshotLookupByName(cmd.getTarget().getSnapshotName());
 
+            s_logger.debug("Suspending domain " + vmName);
+            dm.suspend(); // suspend the vm to avoid image corruption
 
 Review comment:
   @weizhouapache can you wrap this in a state check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services