[GitHub] [echarts] ssthouse commented on a change in pull request #15207: fix: hightlight multiple series not work as expected

[GitBox <gi...@apache.org>]

ssthouse commented on a change in pull request #15207:
URL: https://github.com/apache/echarts/pull/15207#discussion_r662703008



##########
File path: src/util/states.ts
##########
@@ -454,7 +457,8 @@ export function blurSeries(
             || blurScope === 'coordinateSystem' && !sameCoordSys
             // Not blur self series if focus is series.
             || focus === 'series' && sameSeries
-            // TODO blurScope: coordinate system
+            // Not blur other series if focus is self
+            || focus === 'self' && !sameSeries

Review comment:
       @pissang Hi，I found it's complicated to first blur then highlight for each series, like this;
   ```javascript
   for(const series of seriesList){
       blurNecessaryPart(series);
       highlightCurrent(series);
   }
   ```
   
   Since the previous highlighted series can be easily blurred by the latter series;
   It may be more clear if we first blur all the necessary parts then hight all the necessary parts, like this;
   
   ```javascript
   for(const series of seriesList){
       blurNecessaryPart(series);
   }
   for(const series of seriesList){
       highlightCurrent(series);
   }
   ```
   
   I modified the current code to this scenario and tested with `npm run test:visual`, please take a look~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org