You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "torwig (via GitHub)" <gi...@apache.org> on 2025/03/07 16:28:33 UTC

Re: [PR] feat: Added iso8601 time format parameter to LASTSAVE command. [kvrocks]

torwig commented on code in PR #2822:
URL: https://github.com/apache/kvrocks/pull/2822#discussion_r1985359745


##########
src/commands/cmd_server.cc:
##########
@@ -1006,12 +1008,42 @@ static uint64_t GenerateConfigFlag(uint64_t flags, const std::vector<std::string
 
 class CommandLastSave : public Commander {
  public:
+  Status Parse(const std::vector<std::string> &args) override {
+    if (args.size() > 2) {
+      return {Status::RedisParseErr, "unknown extra subcommand"};
+    }
+    if (args.size() == 2) {
+      std::string fmt_arg = args[1];

Review Comment:
   You can try to use `EqualICase` (common->string_util.h).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org