You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sunchao (via GitHub)" <gi...@apache.org> on 2023/07/14 19:56:03 UTC
[GitHub] [spark] sunchao commented on a diff in pull request #41990: [SPARK-42454][SQL] SPJ: encapsulate all SPJ related parameters in BatchScanExec
sunchao commented on code in PR #41990:
URL: https://github.com/apache/spark/pull/41990#discussion_r1264099776
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -241,3 +243,24 @@ case class BatchScanExec(
s"BatchScan ${table.name()}".trim
}
}
+
+case class StoragePartitionJoinParams(
+ keyGroupedPartitioning: Option[Seq[Expression]] = None,
+ commonPartitionValues: Option[Seq[(InternalRow, Int)]] = None,
+ applyPartialClustering: Boolean = false,
+ replicatePartitions: Boolean = false) {
+ override def equals(other: Any): Boolean = other match {
+ case other: StoragePartitionJoinParams =>
+ this.commonPartitionValues == other.commonPartitionValues &&
+ this.replicatePartitions == other.replicatePartitions &&
+ this.applyPartialClustering == other.applyPartialClustering
+ case _ =>
+ false
+ }
+
+ override def hashCode(): Int = Objects.hashCode(
+ commonPartitionValues: Option[Seq[(InternalRow, Int)]],
Review Comment:
nit: why do we need to explicitly specify the types here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org