You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ta...@apache.org on 2023/11/13 10:15:35 UTC

(iotdb) branch master updated: [IOTDB-6247] Remove redundant error log when restarting simple consensus ConfigNode (#11529)

This is an automated email from the ASF dual-hosted git repository.

tanxinyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 918ee105303 [IOTDB-6247] Remove redundant error log when restarting simple consensus ConfigNode  (#11529)
918ee105303 is described below

commit 918ee105303ff7f8b4bbd116970f425626db4a3d
Author: Yongzao <yo...@apache.org>
AuthorDate: Mon Nov 13 18:15:28 2023 +0800

    [IOTDB-6247] Remove redundant error log when restarting simple consensus ConfigNode  (#11529)
---
 .../confignode/manager/consensus/ConsensusManager.java    | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java
index 0a260f2f91c..b63fc8238c7 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java
@@ -27,7 +27,6 @@ import org.apache.iotdb.commons.conf.CommonConfig;
 import org.apache.iotdb.commons.conf.CommonDescriptor;
 import org.apache.iotdb.commons.consensus.ConfigRegionId;
 import org.apache.iotdb.commons.consensus.ConsensusGroupId;
-import org.apache.iotdb.commons.exception.BadNodeUrlException;
 import org.apache.iotdb.confignode.conf.ConfigNodeConfig;
 import org.apache.iotdb.confignode.conf.ConfigNodeDescriptor;
 import org.apache.iotdb.confignode.conf.SystemPropertiesUtils;
@@ -209,20 +208,6 @@ public class ConsensusManager {
     }
     consensusImpl.start();
     if (SystemPropertiesUtils.isRestarted()) {
-      // TODO: @Itami-Sho Check and notify if current ConfigNode's ip or port has changed
-
-      if (SIMPLE_CONSENSUS.equals(CONF.getConfigNodeConsensusProtocolClass())) {
-        // Only SIMPLE_CONSENSUS need invoking `createPeerForConsensusGroup` when restarted,
-        // but RATIS_CONSENSUS doesn't need it
-        try {
-          createPeerForConsensusGroup(SystemPropertiesUtils.loadConfigNodeList());
-        } catch (BadNodeUrlException e) {
-          throw new IOException(e);
-        } catch (ConsensusException e) {
-          LOGGER.error(
-              "Something wrong happened while calling consensus layer's createLocalPeer API.", e);
-        }
-      }
       LOGGER.info("Init ConsensusManager successfully when restarted");
     } else if (ConfigNodeDescriptor.getInstance().isSeedConfigNode()) {
       // Create ConsensusGroup that contains only itself