[GitHub] [maven] michael-o commented on a change in pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #459:
URL: https://github.com/apache/maven/pull/459#discussion_r598984435



##########
File path: maven-core/src/test/java/org/apache/maven/graph/DefaultGraphBuilderTest.java
##########
@@ -390,6 +400,7 @@ private Dependency toDependency( MavenProject mavenProject )
         private String resumeFrom = "";
         private String makeBehavior = "";
         private File requestedPom = new File( PARENT_MODULE, "pom.xml" );
+        private boolean isRecursive = true;

Review comment:
       Shouldn't this just be `recursive`?

##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##########
@@ -284,20 +284,7 @@ public DefaultGraphBuilder( BuildResumptionDataRepository buildResumptionDataRep
             excludedProjects.addAll( getProjectsBySelectors( request, projects, optionalSelectors, false ) );
 
             result = new ArrayList<>( projects );
-
-            for ( MavenProject excludedProject : excludedProjects )

Review comment:
       Wasn't this removed in an another commit recently?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org