[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11083: feat: custom favorite filter for dashboards, charts and saved queries

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #11083:
URL: https://github.com/apache/incubator-superset/pull/11083#discussion_r496526146



##########
File path: superset/charts/filters.py
##########
@@ -44,6 +45,17 @@ def apply(self, query: Query, value: Any) -> Query:
         )
 
 
+class ChartFavoriteFilter(BaseFavoriteFilter):  # pylint: disable=too-few-public-methods
+    """
+    Custom filter for the GET list that filters all charts that a user has favored
+    """
+
+    name = _("Is favorite")
+    arg_name = "chart_is_fav"

Review comment:
       I can't these are global




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org