[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Delta, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

[GitBox <gi...@apache.org>]

JonasJ-ap commented on code in PR #6449:
URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056753664


##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -161,7 +161,7 @@ private static Metrics getAvroMetrics(Path path, Configuration conf) {
     }
   }
 
-  private static Metrics getParquetMetrics(
+  public static Metrics getParquetMetrics(

Review Comment:
   Thank you for your suggestion. It seems doing so would mean copy-pase the `getParquetMetrics` from `TableMigrationUtil` to `BaseMigrateDeltaLakeTableAction`. I think the trade-off here is between duplicated code section and exposing private methods. Given that the class named `TableMigrationUtil` is intended to provide util methods for table migration, do you think it may be proper to make these methods public in this case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org