You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/05/08 20:27:34 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #697: ORC-795: Add LineLength checkstyle rule

dongjoon-hyun commented on a change in pull request #697:
URL: https://github.com/apache/orc/pull/697#discussion_r628792833



##########
File path: java/pom.xml
##########
@@ -279,6 +279,9 @@
                 </module>
                 <module name="NewlineAtEndOfFile">
                 </module>
+                <module name="LineLength">
+                  <property name="max" value="125"/>

Review comment:
       Thank you, @williamhyun . Got it. I checked with `<property name="max" value="100"/>` and `<failOnViolation>false</failOnViolation>` and realized that we have too many instances after this PR. We had better reduce this gradually to 100 or 80 later.
   
   ```
   $ mvn checkstyle:check -Panalyze | grep ERROR | wc -l
   Using `mvn` from path: /usr/local/bin/mvn
         69
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org