You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/06/04 14:53:46 UTC
Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1
upgrades
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Description
-------
Encrypt system.vm.password and make the configuration as Secure.
This addresses bug CLOUDSTACK-1012.
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java 9e386b9
Diff: https://reviews.apache.org/r/11627/diff/
Testing
-------
Tested on local setup.
Build successful.
Thanks,
Saksham Srivastava
RE: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for
4.0 to 4.1 upgrades
Posted by Saksham Srivastava <sa...@citrix.com>.
In 4.1 during encryption the category was made 'Secure'.
So this will check if encryption is actually needed and will prevent encrypting twice. Unencrypted value will have category as 'Hidden'.
I will wait for 4.1.1 upgrade path and add the fix then.
Thanks,
Saksham
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Wednesday, June 05, 2013 12:40 AM
To: dev@cloudstack.apache.org; Chiradeep Vittal
Cc: Kishan Kavala; Saksham Srivastava; cloudstack
Subject: Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades
Also, we already released 4.1.0. If this is needed, how should it be correctly done for a 4.1.1 release?
On Tue, Jun 04, 2013 at 05:03:49PM +0000, Chiradeep Vittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/#review21422
> -----------------------------------------------------------
>
>
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java
> <https://reviews.apache.org/r/11627/#comment44357>
>
> The logic is not clear. Can you add a few comments and logs as to WHY the system vm password is being updated?
>
>
> - Chiradeep Vittal
>
>
> On June 4, 2013, 12:53 p.m., Saksham Srivastava wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11627/
> > -----------------------------------------------------------
> >
> > (Updated June 4, 2013, 12:53 p.m.)
> >
> >
> > Review request for cloudstack and Kishan Kavala.
> >
> >
> > Description
> > -------
> >
> > Encrypt system.vm.password and make the configuration as Secure.
> >
> >
> > This addresses bug CLOUDSTACK-1012.
> >
> >
> > Diffs
> > -----
> >
> > engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java 9e386b9
> >
> > Diff: https://reviews.apache.org/r/11627/diff/
> >
> >
> > Testing
> > -------
> >
> > Tested on local setup.
> > Build successful.
> >
> >
> > Thanks,
> >
> > Saksham Srivastava
> >
> >
>
Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for
4.0 to 4.1 upgrades
Posted by Chip Childers <ch...@sungard.com>.
Also, we already released 4.1.0. If this is needed, how should it be
correctly done for a 4.1.1 release?
On Tue, Jun 04, 2013 at 05:03:49PM +0000, Chiradeep Vittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/#review21422
> -----------------------------------------------------------
>
>
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java
> <https://reviews.apache.org/r/11627/#comment44357>
>
> The logic is not clear. Can you add a few comments and logs as to WHY the system vm password is being updated?
>
>
> - Chiradeep Vittal
>
>
> On June 4, 2013, 12:53 p.m., Saksham Srivastava wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11627/
> > -----------------------------------------------------------
> >
> > (Updated June 4, 2013, 12:53 p.m.)
> >
> >
> > Review request for cloudstack and Kishan Kavala.
> >
> >
> > Description
> > -------
> >
> > Encrypt system.vm.password and make the configuration as Secure.
> >
> >
> > This addresses bug CLOUDSTACK-1012.
> >
> >
> > Diffs
> > -----
> >
> > engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java 9e386b9
> >
> > Diff: https://reviews.apache.org/r/11627/diff/
> >
> >
> > Testing
> > -------
> >
> > Tested on local setup.
> > Build successful.
> >
> >
> > Thanks,
> >
> > Saksham Srivastava
> >
> >
>
Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to
4.1 upgrades
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/#review21422
-----------------------------------------------------------
engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java
<https://reviews.apache.org/r/11627/#comment44357>
The logic is not clear. Can you add a few comments and logs as to WHY the system vm password is being updated?
- Chiradeep Vittal
On June 4, 2013, 12:53 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Description
> -------
>
> Encrypt system.vm.password and make the configuration as Secure.
>
>
> This addresses bug CLOUDSTACK-1012.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java 9e386b9
>
> Diff: https://reviews.apache.org/r/11627/diff/
>
>
> Testing
> -------
>
> Tested on local setup.
> Build successful.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0
to 4.1 upgrades
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/#review22461
-----------------------------------------------------------
server/src/com/cloud/upgrade/dao/Upgrade410to411.java
<https://reviews.apache.org/r/11627/#comment46018>
table name should be 'cloud'.'configuration', same for other queries
- Kishan Kavala
On June 24, 2013, 5:36 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/
> -----------------------------------------------------------
>
> (Updated June 24, 2013, 5:36 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-1012
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Encrypt system.vm.password and make the configuration as Secure.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/dao/Upgrade410to411.java 5b25620
>
> Diff: https://reviews.apache.org/r/11627/diff/
>
>
> Testing
> -------
>
> Tested on local setup.
> Build successful.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0
to 4.1 upgrades
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/#review22764
-----------------------------------------------------------
Ship it!
commit 3128a4ccee0b8e9d990601bcf72399390e9239ba
- Kishan Kavala
On June 28, 2013, 1:54 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 1:54 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-1012
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Encrypt system.vm.password and make the configuration as Secure.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/dao/Upgrade410to411.java 5b25620
>
> Diff: https://reviews.apache.org/r/11627/diff/
>
>
> Testing
> -------
>
> Tested on local setup.
> Build successful.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0
to 4.1 upgrades
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/#review22763
-----------------------------------------------------------
Commit 3128a4ccee0b8e9d990601bcf72399390e9239ba in branch refs/heads/4.1 from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3128a4c ]
CLOUDSTACK-1012:Encrypt system.vm.password for 4.1 to 4.1.1 upgrades
- ASF Subversion and Git Services
On June 28, 2013, 8:24 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 8:24 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-1012
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Encrypt system.vm.password and make the configuration as Secure.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/dao/Upgrade410to411.java 5b25620
>
> Diff: https://reviews.apache.org/r/11627/diff/
>
>
> Testing
> -------
>
> Tested on local setup.
> Build successful.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0
to 4.1 upgrades
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/
-----------------------------------------------------------
(Updated June 28, 2013, 8:24 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-1012
Repository: cloudstack-git
Description
-------
Encrypt system.vm.password and make the configuration as Secure.
Diffs (updated)
-----
server/src/com/cloud/upgrade/dao/Upgrade410to411.java 5b25620
Diff: https://reviews.apache.org/r/11627/diff/
Testing
-------
Tested on local setup.
Build successful.
Thanks,
Saksham Srivastava
Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to
4.1 upgrades
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/
-----------------------------------------------------------
(Updated June 24, 2013, 12:06 p.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
Changing the upgrade file.
Description
-------
Encrypt system.vm.password and make the configuration as Secure.
This addresses bug CLOUDSTACK-1012.
Diffs (updated)
-----
server/src/com/cloud/upgrade/dao/Upgrade410to411.java 5b25620
Diff: https://reviews.apache.org/r/11627/diff/
Testing
-------
Tested on local setup.
Build successful.
Thanks,
Saksham Srivastava