You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/05/16 02:18:41 UTC
[Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
#80: Use Bootstrap pagination in widgets rendering grids
----------------------------------------------+--------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Keywords: grid widget bootstrap pagination |
----------------------------------------------+--------------------
Use [http://twitter.github.com/bootstrap/components.html#pagination
Bootstrap pagination rules] rather than default ''Trac'' pagination inside
widgets . So far , the only candidate for update seems to be
`widget_grid.html` .
'''Hint:''' This has been already implemented for #10 in theme plugin , so
bootstrap pagination template should be moved to dashboard plugin and
reused in there by widgets .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 4
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by olemis):
Replying to [comment:9 gjm]:
> It seems I forgot to mention why I was not going to apply the patch as
suggested:
>
I understood what's been said , but I don't understand what shall I do .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by gjm):
Replying to [comment:3 jdreimann]:
> I'll have a look at this in the morning.. the full Bootstrap pagination
seems too intrusive here. We may just want to move the default styled
pagination to the bottom of the table for now, and move away from
pagination for tables like this in future (as per the html templates).
OK, the code Olemis provided should be easy to apply and make work at the
bottom of the page so we could leave that aspect to the next milestone to
see if it can be made less intrustive too.
Moving the current pagination to the bottom should be fine for now though.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Changes (by olemis):
* owner: nobody => olemis
* status: new => accepted
* milestone: => RC1 for initial release
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by olemis):
Pagination template needs to be moved to dashboard plugin , because other
templates defined in other plugins might use it as well . Reusable UI
assets should be placed in dashboard plugin rather than theme .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: gjm
Type: enhancement | Status: closed
Priority: minor | Milestone: Release 5
Component: dashboard | Version:
Resolution: invalid | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Changes (by gjm):
* status: assigned => closed
* resolution: => invalid
Comment:
I take it that this is considered invalid.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by olemis):
Attached patches implement this feature . The one removing page index
template from theme should be applied against r1340111 whereas the one
including it in dashboard has to applied against r1339633 .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by gjm):
Replying to [comment:5 olemis]:
> Pagination template needs to be moved to dashboard plugin , because
other templates defined in other plugins might use it as well . Reusable
UI assets should be placed in dashboard plugin rather than theme .
That is fine. I believe that jdreimann is only talking about moving things
around and that should be possible without reference your patch. We will
look at converting to the bootstrap pagination later re-using your patch
as the basis. I do not expect it to require many changes as long as the
behaviour is what we want.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by jdreimann):
I'll have a look at this in the morning.. the full Bootstrap pagination
seems too intrusive here. We may just want to move the default styled
pagination to the bottom of the table for now, and move away from
pagination for tables like this in future (as per the html templates).
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Olemis Lang <ol...@gmail.com>.
On 12/11/12, Olemis Lang <ol...@gmail.com> wrote:
> Bootstrap pagination will not be included at the bottom of widgets
> because it's overkill , agreed . However it should be included in e.g.
> /query and /report views . That's not happening at the moment afaics .
> I don't know if this ticket is the right to implement such enhancement
> . I do remember I created a ticket for that ...
>
gotcha ! :)
it's #166
;)
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Olemis Lang <ol...@gmail.com>.
Bootstrap pagination will not be included at the bottom of widgets
because it's overkill , agreed . However it should be included in e.g.
/query and /report views . That's not happening at the moment afaics .
I don't know if this ticket is the right to implement such enhancement
. I do remember I created a ticket for that ...
On 12/10/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #80: Use Bootstrap pagination in widgets rendering grids
> --------------------------+----------------------------------------------
> Reporter: olemis | Owner: olemis
> Type: enhancement | Status: assigned
> Priority: minor | Milestone: Release 4
> Component: dashboard | Version:
> Resolution: | Keywords: grid widget bootstrap pagination
> --------------------------+----------------------------------------------
>
> Comment (by gjm):
>
> Replying to [comment:10 olemis]:
> > Replying to [comment:9 gjm]:
> > > It seems I forgot to mention why I was not going to apply the patch as
> suggested:
> > >
> >
> > I understood what's been said , but I don't understand what shall I do .
>
> Sorry.. just sending it back in case there was anything I missed. Do we
> need to keep this ticket?
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:11>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 4
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by gjm):
Replying to [comment:10 olemis]:
> Replying to [comment:9 gjm]:
> > It seems I forgot to mention why I was not going to apply the patch as
suggested:
> >
>
> I understood what's been said , but I don't understand what shall I do .
Sorry.. just sending it back in case there was anything I missed. Do we
need to keep this ticket?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: gjm
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 4
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Changes (by olemis):
* owner: olemis => gjm
Comment:
I see no reason for moving forward with this ticket . If you share the
same vision , just close it (resolution TBD) . IMO we should continue with
#166 though .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: gjm
Type: enhancement | Status: review
Priority: minor | Milestone: Release 3
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Changes (by olemis):
* status: accepted => review
* owner: olemis => gjm
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Comment (by olemis):
Replying to [comment:6 gjm]:
> Replying to [comment:5 olemis]:
> > Pagination template needs to be moved to dashboard plugin , because
other templates defined in other plugins might use it as well . Reusable
UI assets should be placed in dashboard plugin rather than theme .
>
> That is fine. I believe that jdreimann is only talking about moving
things around and that should be possible without reference your patch.
Let me explain myself better then ... my previous comment was intended to
let you know that [attachment:t80_r1340111_rm_page_index.diff] should
still be applied (... I applied it against r1354639 and it still works
without modifications ''';)''' . So I'll split the other patch to be
applied in two steps
1. include pagination template in dashboard and insert links at the
bottom of widgets
2. default conversion to bootstrap styling
> We will look at converting to the bootstrap pagination later re-using
your patch as the basis. I do not expect it to require many changes as
long as the behaviour is what we want.
... hence it will be possible to apply '''1''' and postpone '''2''' .
That's what I had in mind .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #80: Use Bootstrap pagination in widgets
rendering grids
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#80: Use Bootstrap pagination in widgets rendering grids
--------------------------+----------------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 4
Component: dashboard | Version:
Resolution: | Keywords: grid widget bootstrap pagination
--------------------------+----------------------------------------------
Changes (by gjm):
* status: review => assigned
* owner: gjm => olemis
Comment:
It seems I forgot to mention why I was not going to apply the patch as
suggested:
{{{
#!sh
svn blame bhtheme/templates/bh_search.html |grep bh_page_index
1333006 gjm <xi:include py:with="paginator = results"
href="bh_page_index.html" />
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/80#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker