You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Hao Hao <ha...@cloudera.com> on 2015/12/01 00:23:24 UTC
Re: Review Request 40677: SENTRY835: Drop table leaves a connection
open when using metastorelistener.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40677/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 11:23 p.m.)
Review request for sentry, Anne Yu, Lenni Kuff, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
Change-Id: I4b31ff944da604bf416239ed7cb3f147dffa8cb9
Found the issue is caused by the connection is not properly closed after drop table/database event occurs on metastore. Fix it and modified the test.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java ecdfe1f24e6d32d232a6e7d61ee502b2153f5551
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java 3c9908c7ed3469ad9c3dcc7399272ca6878ff87e
Diff: https://reviews.apache.org/r/40677/diff/
Testing
-------
Tested on TestDbConnections.
Thanks,
Hao Hao
Re: Review Request 40677: SENTRY835: Drop table leaves a connection
open when using metastorelistener.
Posted by Anne Yu <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40677/#review108454
-----------------------------------------------------------
Ship it!
Ship It!
- Anne Yu
On Nov. 30, 2015, 11:23 p.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40677/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 11:23 p.m.)
>
>
> Review request for sentry, Anne Yu, Lenni Kuff, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Change-Id: I4b31ff944da604bf416239ed7cb3f147dffa8cb9
>
> Found the issue is caused by the connection is not properly closed after drop table/database event occurs on metastore. Fix it and modified the test.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java ecdfe1f24e6d32d232a6e7d61ee502b2153f5551
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java 3c9908c7ed3469ad9c3dcc7399272ca6878ff87e
>
> Diff: https://reviews.apache.org/r/40677/diff/
>
>
> Testing
> -------
>
> Tested on TestDbConnections.
>
>
> Thanks,
>
> Hao Hao
>
>