You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sc...@apache.org on 2006/04/10 03:26:27 UTC
svn commit: r392869 -
/myfaces/core/branches/1_1_2/api/src/main/java/javax/faces/component/_ComponentAttributesMap.java
Author: schof
Date: Sun Apr 9 18:26:25 2006
New Revision: 392869
URL: http://svn.apache.org/viewcvs?rev=392869&view=rev
Log:
Revert changes made to fix MYFACES-458. Fix caused massive TCK failure. Revisit once 1.1.2 is released.
Modified:
myfaces/core/branches/1_1_2/api/src/main/java/javax/faces/component/_ComponentAttributesMap.java
Modified: myfaces/core/branches/1_1_2/api/src/main/java/javax/faces/component/_ComponentAttributesMap.java
URL: http://svn.apache.org/viewcvs/myfaces/core/branches/1_1_2/api/src/main/java/javax/faces/component/_ComponentAttributesMap.java?rev=392869&r1=392868&r2=392869&view=diff
==============================================================================
--- myfaces/core/branches/1_1_2/api/src/main/java/javax/faces/component/_ComponentAttributesMap.java (original)
+++ myfaces/core/branches/1_1_2/api/src/main/java/javax/faces/component/_ComponentAttributesMap.java Sun Apr 9 18:26:25 2006
@@ -298,7 +298,7 @@
*/
public Object put(Object key, Object value)
{
- checkKeyAndValue(key);
+ checkKeyAndValue(key, value);
PropertyDescriptor propertyDescriptor = getPropertyDescriptor((String)key);
if (propertyDescriptor != null)
@@ -420,12 +420,12 @@
}
- private void checkKeyAndValue(Object key)
+ private void checkKeyAndValue(Object key, Object value)
{
//http://issues.apache.org/jira/browse/MYFACES-458: obviously, the spec is a little unclear here,
// but value == null should be allowed - if there is a TCK-test failing due to this, we should
// apply for getting the TCK-test dropped
- // if (value == null) throw new NullPointerException("value");
+ if (value == null) throw new NullPointerException("value");
checkKey(key);
}