[GitHub] [ignite-3] kgusakov commented on a diff in pull request #881: IGNITE-16955 Improve logging for rebalance process

[GitBox <gi...@apache.org>]

kgusakov commented on code in PR #881:
URL: https://github.com/apache/ignite-3/pull/881#discussion_r905035152


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/RebalanceRaftGroupEventsListener.java:
##########
@@ -140,6 +140,10 @@ public void onLeaderElected(long term) {
                     if (!pendingEntry.empty()) {
                         List<ClusterNode> pendingNodes = (List<ClusterNode>) ByteUtils.fromBytes(pendingEntry.value());
 
+                        LOG.info("New leader elected for the raft group={} "
+                                        + "of partition={}, table={} and pending reconfiguration to peers={} discovered",
+                                partId, partNum, tblConfiguration.name().value(), pendingNodes);
+

Review Comment:
   Are you sure that we really need it? I mean - we already have logging inside the changePeersAsync on the server/client side and before it in listeners, also separate messages about problems and retries in movePartition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org