You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/08 09:11:28 UTC

[GitHub] [shenyu] youzipi opened a new pull request, #4245: perf: replace `Collection.size()` with `isEmpty`

youzipi opened a new pull request, #4245:
URL: https://github.com/apache/shenyu/pull/4245

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   
   Some Collection's `size` is an `O(n)` operation.
   we should always prefer `isEmpty` when we what to check if collection is empty.
   Make sure that:
   
   - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [x] You submit test cases (unit or integration tests) that back your changes.
   - [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] li-keguo merged pull request #4245: perf: replace `Collection.size()` with `isEmpty`

Posted by GitBox <gi...@apache.org>.
li-keguo merged PR #4245:
URL: https://github.com/apache/shenyu/pull/4245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org