[Impala-ASF-CR] IMPALA-10429 Add Support for Spilling to HDFS Path Parsing

["Abhishek Rawat (Code Review)" <ge...@cloudera.org>]

Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17720 )

Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17720/2/be/src/runtime/tmp-file-mgr-test.cc
File be/src/runtime/tmp-file-mgr-test.cc:

http://gerrit.cloudera.org:8080/#/c/17720/2/be/src/runtime/tmp-file-mgr-test.cc@1021
PS2, Line 1021:       CreateTmpFileMgr("hdfs://localhost:20500/tmp,/tmp/local-buffer-dir"));
If there is no local buffer, is that case not supported? Either way we should add a unit test for that scenario also.


http://gerrit.cloudera.org:8080/#/c/17720/2/be/src/runtime/tmp-file-mgr-test.cc@1031
PS2, Line 1031:       CreateTmpFileMgr("hdfs://localhost:20500/tmp:1KB:1,/tmp/local-buffer-dir"));
Is one remote dir and multiple local dirs valid configuration? In that case, the first one is used as buffer for remote? Would be good to add unit test for that scenario also.



-- 
To view, visit http://gerrit.cloudera.org:8080/17720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0882ed1e80b02724dd5cb3cdb1fa7b6c2debcbf4
Gerrit-Change-Number: 17720
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 22:48:49 +0000
Gerrit-HasComments: Yes