You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/07 21:47:48 UTC

[GitHub] [kafka] hachikuji edited a comment on pull request #10986: KAFKA-12983: reset needsJoinPrepare flag before rejoining the group

hachikuji edited a comment on pull request #10986:
URL: https://github.com/apache/kafka/pull/10986#issuecomment-875956460


   @ableegoldman Thanks for the patch. I think the original idea behind the implementation was to ensure that each rebalance triggered only one call to `onPartitionsRevoked`. It sounds like this needs some refinement for the cooperative rebalance logic. I guess the main difference is that we could now have a call to `onPartitionsLost` if the memberId is lost after the initial call to `onJoinPrepare`? It might be nice to ensure that we can keep the same behavior for eager rebalancing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org