You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/14 11:47:02 UTC
[GitHub] [calcite] cshuo opened a new pull request #1758: [CALCITE-3721]
Filter of distinct aggregate call is lost after applying
`AggregateExpandDistinctAggregatesRule`
cshuo opened a new pull request #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`
URL: https://github.com/apache/calcite/pull/1758
In `AggregateExpandDistinctAggregatesRule`, when the distinct aggregate call is rewritten using
groupingSets, the filter of the distinct aggregate call itself is lost unexpected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 closed pull request #1758: [CALCITE-3721]
Filter of distinct aggregate call is lost after applying
`AggregateExpandDistinctAggregatesRule`
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`
URL: https://github.com/apache/calcite/pull/1758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi commented on issue #1758: [CALCITE-3721] Filter of
distinct aggregate call is lost after applying
`AggregateExpandDistinctAggregatesRule`
Posted by GitBox <gi...@apache.org>.
vlsi commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`
URL: https://github.com/apache/calcite/pull/1758#issuecomment-574137406
Please refrain from re-creating PRs with exactly the same changes. It loses history and conversations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] xy2953396112 commented on issue #1758: [CALCITE-3721]
Filter of distinct aggregate call is lost after applying
`AggregateExpandDistinctAggregatesRule`
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`
URL: https://github.com/apache/calcite/pull/1758#issuecomment-574148644
Maybe you can squash commits and keep a discussion in one PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] cshuo commented on issue #1758: [CALCITE-3721] Filter of
distinct aggregate call is lost after applying
`AggregateExpandDistinctAggregatesRule`
Posted by GitBox <gi...@apache.org>.
cshuo commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`
URL: https://github.com/apache/calcite/pull/1758#issuecomment-574137414
See [pull/1741](https://github.com/apache/calcite/pull/1741) for discussion details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] cshuo commented on issue #1758: [CALCITE-3721] Filter of
distinct aggregate call is lost after applying
`AggregateExpandDistinctAggregatesRule`
Posted by GitBox <gi...@apache.org>.
cshuo commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`
URL: https://github.com/apache/calcite/pull/1758#issuecomment-574140805
> Please refrain from re-creating PRs with exactly the same changes. It loses history and conversations.
Hi, vlsi, I delete my pull branch by misoperation, and the origin PR can not be reopened...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services