You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/24 16:31:24 UTC
[GitHub] [camel] attrobit opened a new pull request #4921: camel-milo: enabled connection caching again.
attrobit opened a new pull request #4921:
URL: https://github.com/apache/camel/pull/4921
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] attrobit closed pull request #4921: camel-milo: enabled connection caching again.
Posted by GitBox <gi...@apache.org>.
attrobit closed pull request #4921:
URL: https://github.com/apache/camel/pull/4921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] attrobit commented on pull request #4921: camel-milo: enabled connection caching again.
Posted by GitBox <gi...@apache.org>.
attrobit commented on pull request #4921:
URL: https://github.com/apache/camel/pull/4921#issuecomment-766390880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] attrobit commented on pull request #4921: camel-milo: enabled connection caching again.
Posted by GitBox <gi...@apache.org>.
attrobit commented on pull request #4921:
URL: https://github.com/apache/camel/pull/4921#issuecomment-766413102
Currently the connection get closed when component stops. But i think that is to late. I want to close the connection when the routes stops.
How does the component recognizes when all routes stops?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4921: camel-milo: enabled connection caching again.
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4921:
URL: https://github.com/apache/camel/pull/4921#issuecomment-768337069
There is a ticket to make this better and similar to messaging components where there is a SPI
https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-16094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] attrobit commented on pull request #4921: camel-milo: enabled connection caching again.
Posted by GitBox <gi...@apache.org>.
attrobit commented on pull request #4921:
URL: https://github.com/apache/camel/pull/4921#issuecomment-766390880
> Wasn't this removed?
Yes, but i down know why. For me the caching are useful and for my usecases necessary. I will have round about 400 routes to the same OPC-UA server. I think it is not a good idea to have for each route a separate connection.
The difference to the old version is that the connection are not created on component start. Now the connection instance are later careted on consumer or producer start.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] attrobit closed pull request #4921: camel-milo: enabled connection caching again.
Posted by GitBox <gi...@apache.org>.
attrobit closed pull request #4921:
URL: https://github.com/apache/camel/pull/4921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org