You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mingleizhang (JIRA)" <ji...@apache.org> on 2017/04/24 02:59:04 UTC
[jira] [Issue Comment Deleted] (FLINK-5855) Unprotected access to
pendingFilesPerCheckpoint in BucketingSink
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
mingleizhang updated FLINK-5855:
--------------------------------
Comment: was deleted
(was: Yep. That is right. So, follow your suggestion. I would write the code snippet like Correct ?{code}
synchronized (restoredState.pendingFilesPerCheckpoint) {
restoredState.pendingFilesPerCheckpoint.clear();
}
handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
{code})
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
> ----------------------------------------------------------------
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Reporter: Ted Yu
> Priority: Minor
>
> {code} handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)