You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 04:11:53 UTC
[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #29: Generate
GraphQL codes dynamically
kezhenxu94 opened a new pull request #29: Generate GraphQL codes dynamically
URL: https://github.com/apache/skywalking-cli/pull/29
This patch respects to the way to handle query protocol in Java, generating Go codes when building, and add query protocol as submodule, reducing efforts to maintain the changing protocol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request
#29: Generate GraphQL codes dynamically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #29: Generate GraphQL codes dynamically
URL: https://github.com/apache/skywalking-cli/pull/29#discussion_r387461488
##########
File path: dist/LICENSE
##########
@@ -222,6 +222,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
sirupsen (logrus) 1.4.2: https://github.com/sirupsen/logrus MIT
urfave (cli) 1.22.1: https://github.com/urfave/cli MIT
nsf (termbox-go) 0.0.0-20190817171036-93860e161317: https://github.com/nsf/termbox-go MIT
+ 99designs (gqlgen) 0.11.1: https://github.com/99designs/gqlgen MIT
Review comment:
Why is this added in the dist release? Is this something missed before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io commented on issue #29: Generate
GraphQL codes dynamically
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #29: Generate GraphQL codes dynamically
URL: https://github.com/apache/skywalking-cli/pull/29#issuecomment-594317264
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=h1) Report
> Merging [#29](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/faecb18527cd59772d1b7ca01b0a410470345322?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 6 6
Lines 101 101
=======================================
Hits 55 55
Misses 39 39
Partials 7 7
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=footer). Last update [faecb18...0a9b99a](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #29: Generate
GraphQL codes dynamically
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #29: Generate GraphQL codes dynamically
URL: https://github.com/apache/skywalking-cli/pull/29#issuecomment-594317264
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=h1) Report
> Merging [#29](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/faecb18527cd59772d1b7ca01b0a410470345322?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 6 6
Lines 101 101
=======================================
Hits 55 55
Misses 39 39
Partials 7 7
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=footer). Last update [faecb18...e4af535](https://codecov.io/gh/apache/skywalking-cli/pull/29?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng merged pull request #29: Generate GraphQL
codes dynamically
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #29: Generate GraphQL codes dynamically
URL: https://github.com/apache/skywalking-cli/pull/29
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request
#29: Generate GraphQL codes dynamically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #29: Generate GraphQL codes dynamically
URL: https://github.com/apache/skywalking-cli/pull/29#discussion_r387468771
##########
File path: dist/LICENSE
##########
@@ -222,6 +222,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
sirupsen (logrus) 1.4.2: https://github.com/sirupsen/logrus MIT
urfave (cli) 1.22.1: https://github.com/urfave/cli MIT
nsf (termbox-go) 0.0.0-20190817171036-93860e161317: https://github.com/nsf/termbox-go MIT
+ 99designs (gqlgen) 0.11.1: https://github.com/99designs/gqlgen MIT
Review comment:
mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services