You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/01/10 12:29:00 UTC
[jira] [Work logged] (BEAM-13308) [Playground] Getting baseFileFolder from environment
[ https://issues.apache.org/jira/browse/BEAM-13308?focusedWorklogId=706049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706049 ]
ASF GitHub Bot logged work on BEAM-13308:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/22 12:28
Start Date: 10/Jan/22 12:28
Worklog Time Spent: 10m
Work Description: pavel-avilov commented on a change in pull request #16384:
URL: https://github.com/apache/beam/pull/16384#discussion_r781148643
##########
File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper_test.go
##########
@@ -47,16 +48,17 @@ func TestSetup(t *testing.T) {
}
defer os.RemoveAll(workingDir)
- lc, err := fs_tool.NewLifeCycle(playground.Sdk_SDK_JAVA, successPipelineId, workingDir)
+ lc, err := fs_tool.NewLifeCycle(playground.Sdk_SDK_JAVA, successPipelineId, filepath.Join(workingDir, pipelinesFolder))
Review comment:
The test now checks the path with executable_files, so it matter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 706049)
Time Spent: 1h 10m (was: 1h)
> [Playground] Getting baseFileFolder from environment
> ----------------------------------------------------
>
> Key: BEAM-13308
> URL: https://issues.apache.org/jira/browse/BEAM-13308
> Project: Beam
> Issue Type: Task
> Components: beam-playground
> Reporter: Pavel Avilov
> Assignee: Pavel Avilov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-7
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Need to get the baseFileFolder value from the environment variable (now baseFileFolder is a constant). Also in the dockerfile for go SDK change the command "go mod init executable_files" to "go mod init ${PIPELINES_FOLDER_NAME}", where "PIPELINES_FOLDER_NAME" is the name of env. variable for baseFileFolder.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)