You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/05/17 14:28:52 UTC
[GitHub] [celix] pnoltes opened a new pull request #236: Adds gitflow to build etcdlib standalone weekly.
pnoltes opened a new pull request #236:
URL: https://github.com/apache/celix/pull/236
Also updated celix Promise to build weekly instead of nightly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink commented on pull request #236: Adds gitflow to build etcdlib standalone weekly.
Posted by GitBox <gi...@apache.org>.
rlenferink commented on pull request #236:
URL: https://github.com/apache/celix/pull/236#issuecomment-629825368
Also, I just noticed that we have an `ubuntu.yml` for push & pull_requests (Debug) and an `ubuntu-nightly.yml` for nightly builds (RelWithDebInfo). Maybe we should do this for the etcdlib as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #236: Adds gitflow to build etcdlib standalone weekly.
Posted by GitBox <gi...@apache.org>.
pnoltes commented on pull request #236:
URL: https://github.com/apache/celix/pull/236#issuecomment-629840312
> Also, I just noticed that we have an `ubuntu.yml` for push & pull_requests (Debug) and an `ubuntu-nightly.yml` for nightly builds (RelWithDebInfo). Maybe we should do this for the etcdlib as well?
Also for this case I do not think this is needed. The nightly are added to ensure building with RelDefInfo also works. This is done nightly to prevent too much builds.
And because etcdlib is also build in the nigthly builds I do not see added value for creating a separate builds for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on a change in pull request #236: Adds gitflow to build etcdlib standalone weekly.
Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #236:
URL: https://github.com/apache/celix/pull/236#discussion_r426288899
##########
File path: .github/workflows/celix_etcdlib.yml
##########
@@ -0,0 +1,36 @@
+name: Standalone Celix etcdlib Weekly
+
+on:
+ schedule:
+ - cron: '0 0 * * 0'
Review comment:
I want to prevent to much builds. So IMO just once a week to ensure etcdlib still builds as separate project is good enough.
Note that etcdlib is build on every push / PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink merged pull request #236: Adds gitflow to build etcdlib standalone weekly.
Posted by GitBox <gi...@apache.org>.
rlenferink merged pull request #236:
URL: https://github.com/apache/celix/pull/236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink commented on a change in pull request #236: Adds gitflow to build etcdlib standalone weekly.
Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #236:
URL: https://github.com/apache/celix/pull/236#discussion_r426279972
##########
File path: .github/workflows/celix_etcdlib.yml
##########
@@ -0,0 +1,36 @@
+name: Standalone Celix etcdlib Weekly
+
+on:
+ schedule:
+ - cron: '0 0 * * 0'
Review comment:
We probably want to build this on push & pull_requests as well.
```suggestion
on:
push:
pull_request:
schedule:
- cron: '0 0 * * 0'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink commented on a change in pull request #236: Adds gitflow to build etcdlib standalone weekly.
Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #236:
URL: https://github.com/apache/celix/pull/236#discussion_r426280099
##########
File path: .github/workflows/celix_etcdlib.yml
##########
@@ -0,0 +1,36 @@
+name: Standalone Celix etcdlib Weekly
Review comment:
If we build weekly and on pull requests maybe rename this to:
```suggestion
name: Celix etcdlib (standalone)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org