[GitHub] [doris] morningman commented on a diff in pull request #10977: [feature-wip][multi-catalog] Support s3 storage for file scan node

[GitBox <gi...@apache.org>]

morningman commented on code in PR #10977:
URL: https://github.com/apache/doris/pull/10977#discussion_r923281229


##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalHiveScanProvider.java:
##########
@@ -69,7 +69,13 @@ public TFileFormatType getTableFormatType() throws DdlException, MetaNotFoundExc
     }
 
     @Override
-    public TFileType getTableFileType() {
+    public TFileType getTableFileType() throws MetaNotFoundException {
+        String location = hmsTable.getRemoteTable().getSd().getLocation();
+        if (location != null && !location.isEmpty()) {
+            if (location.startsWith("s3a") || location.startsWith("s3n")) {
+                return TFileType.FILE_S3;
+            }
+        }

Review Comment:
   better to use `if else` to check the location for s3 and hdfs strictly, and throw exception if meeting unknown file type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org