You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "Imbruced (via GitHub)" <gi...@apache.org> on 2025/02/16 21:32:40 UTC

[PR] Add OSM PBF reader. [sedona]

Imbruced opened a new pull request, #1819:
URL: https://github.com/apache/sedona/pull/1819

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   - No, I haven't read it.
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-XXX. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   - No:
     - this is a documentation update. The PR name follows the format `[DOCS] my subject`
     - this is a CI update. The PR name follows the format `[CI] my subject`
   
   
   ## What changes were proposed in this PR?
   
   
   ## How was this patch tested?
   
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I am adding a new API. I am using the [current SNAPSHOT version number](https://github.com/apache/sedona/blob/99239524f17389fc4ae9548ea88756f8ea538bb9/pom.xml#L29) in `vX.Y.Z` format.
   - Yes, I have updated the documentation.
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add OSM PBF reader. [sedona]

Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on PR #1819:
URL: https://github.com/apache/sedona/pull/1819#issuecomment-2665646725

   @jiayuasu, I'm unsure if that's how we want to handle shading the proto. OSM uses proto four, and I think Hadoop is still version 3. I can remove the reader from the spark common, move it to the OSM module, add proto 4, and exclude it from the spark common, as I am already doing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add OSM PBF reader. [sedona]

Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced closed pull request #1819: Add OSM PBF reader.
URL: https://github.com/apache/sedona/pull/1819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add OSM PBF reader. [sedona]

Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on code in PR #1819:
URL: https://github.com/apache/sedona/pull/1819#discussion_r1958831479


##########
spark/common/pom.xml:
##########
@@ -94,6 +99,12 @@
         <dependency>
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-client</artifactId>
+            <exclusions>

Review Comment:
   I think that might be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add OSM PBF reader. [sedona]

Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on code in PR #1819:
URL: https://github.com/apache/sedona/pull/1819#discussion_r1958831479


##########
spark/common/pom.xml:
##########
@@ -94,6 +99,12 @@
         <dependency>
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-client</artifactId>
+            <exclusions>

Review Comment:
   I think this might be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add OSM PBF reader. [sedona]

Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on code in PR #1819:
URL: https://github.com/apache/sedona/pull/1819#discussion_r1958831479


##########
spark/common/pom.xml:
##########
@@ -94,6 +99,12 @@
         <dependency>
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-client</artifactId>
+            <exclusions>

Review Comment:
   I think this might be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add OSM PBF reader. [sedona]

Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on PR #1819:
URL: https://github.com/apache/sedona/pull/1819#issuecomment-2665649121

   I'll create the Jira ticket + add the documentation update. If we agree on implementation, then I'll also copy the code for spark 3.4 and 3.3 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org