[GitHub] [pulsar] BewareMyPower commented on a change in pull request #9074: [feature][cpp-client]Expose cpp end to end encryption interface

[GitBox <gi...@apache.org>]

BewareMyPower commented on a change in pull request #9074:
URL: https://github.com/apache/pulsar/pull/9074#discussion_r549653212



##########
File path: pulsar-client-cpp/include/pulsar/c/producer_configuration.h
##########
@@ -63,8 +63,17 @@ typedef enum {
     pulsar_AutoPublish = -4,
 } pulsar_schema_type;
 
+typedef enum {
+    // This is the default option to fail send if crypto operation fails
+    pulsar_producerFail,
+    // Ignore crypto failure and proceed with sending unencrypted messages
+    pulsar_producerSend

Review comment:
       The naming style should be consistent with other enum values, i.e. change `pulsar_producerFail` to `pulsar_ProducerFail`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org