You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/24 13:48:19 UTC
[GitHub] [cloudstack] FilippoProjetto opened a new pull request #4174: Set prometheus.exporter.enable as not dynamic
FilippoProjetto opened a new pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174
## Description
<!--- Describe your changes in detail -->
Fixes #4173
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-654648402
This is dynamic setting only config, does not require full test run.
Travis has passed tests. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-654648402
This is dynamic setting only config, does not require full test run. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-653725235
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] FilippoProjetto commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
FilippoProjetto commented on pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-648941917
Is it a known flaky test the one failing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-653733175
Packaging result: ✔centos7 ✔debian. JID-1527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4174:
URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-653725190
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org